Add option to provide callback function to iModel action disable prop #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to conditionally disable iModel context menu actions based on the iModel's properties by accepting a callback function for the disabled prop.
Changes:
- Modified
ContextMenuBuilderIteminterface to allowdisabledto be either a boolean or a callback function that receives the iModel value - Updated the menu building logic to evaluate the
disabledprop dynamically when it's a function - Added a new Storybook story demonstrating the disabled callback functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/modules/imodel-browser/src/utils/_buildMenuOptions.tsx | Extended the ContextMenuBuilderItem interface to support callback functions for the disabled prop and updated the menu builder to evaluate it |
| packages/apps/storybook/src/imodel-browser/IModelGrid.stories.tsx | Added example story showing disabled actions based on iModel properties and improved alert message formatting |
| common/changes/@itwin/imodel-browser-react/omar-disable-imodel-action-callback_2026-02-04-21-29.json | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...hanges/@itwin/imodel-browser-react/omar-disable-imodel-action-callback_2026-02-04-21-29.json
Show resolved
Hide resolved
ben-polinsky
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to disable iModel action depending on the iModel
